From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH 03/12] Add udev rule Date: Mon, 19 Oct 2009 16:36:19 +0200 Message-ID: <4ADC7963.10008@siemens.com> References: <20091019105923.3988.42243.stgit@mchn012c.ww002.siemens.net> <20091019105924.3988.4209.stgit@mchn012c.ww002.siemens.net> <4ADC76BF.9050308@codemonkey.ws> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: Avi Kivity , Marcelo Tosatti , "kvm@vger.kernel.org" To: Anthony Liguori Return-path: Received: from david.siemens.de ([192.35.17.14]:21814 "EHLO david.siemens.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755618AbZJSOga (ORCPT ); Mon, 19 Oct 2009 10:36:30 -0400 In-Reply-To: <4ADC76BF.9050308@codemonkey.ws> Sender: kvm-owner@vger.kernel.org List-ID: Anthony Liguori wrote: > Jan Kiszka wrote: >> Ported from OpenSUSE: Provide an udev rule that not only sets the group >> of /dev/kvm but also triggers automatic loading of the kernel modules >> during boot. >> >> Signed-off-by: Jan Kiszka >> --- >> >> Makefile | 1 + >> scripts/65-kvm.rules | 2 ++ >> 2 files changed, 3 insertions(+), 0 deletions(-) >> create mode 100644 scripts/65-kvm.rules >> >> diff --git a/Makefile b/Makefile >> index 8314833..8614449 100644 >> --- a/Makefile >> +++ b/Makefile >> @@ -54,6 +54,7 @@ install: >> if [ -f "$$i" ]; then mv "$$i" "$$i.orig"; fi; \ >> done >> /sbin/depmod -a $(DEPMOD_VERSION) -b $(DESTDIR) >> + install -m 644 -D scripts/65-kvm.rules $(DESTDIR)/etc/udev/rules.d/65-kvm.rules >> > > I believe F12 is installing it 666. If we think it's safe, it's > probably the right thing to do. Err, you mean /dev/kvm, not this rules file, right? Well, in theory it should be safe, but I would currently leave this decision to the person finally building a package out of kvm-kmod or doing some post-install adjustment on a concrete system. Better safe than sorry, specifically as kvm-kmod may contain the latest bleeding edge. Jan -- Siemens AG, Corporate Technology, CT SE 2 Corporate Competence Center Embedded Linux