From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] move tpr stuff to qemu-kvm-x86.c Date: Tue, 20 Oct 2009 08:48:54 +0900 Message-ID: <4ADCFAE6.2060801@redhat.com> References: <1255958965-18471-1-git-send-email-glommer@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Glauber Costa Return-path: Received: from mx1.redhat.com ([209.132.183.28]:10861 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757950AbZJSXsy (ORCPT ); Mon, 19 Oct 2009 19:48:54 -0400 Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n9JNmw9D014230 for ; Mon, 19 Oct 2009 19:48:58 -0400 In-Reply-To: <1255958965-18471-1-git-send-email-glommer@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 10/19/2009 10:29 PM, Glauber Costa wrote: > this whole tpr thing does not belong in common code. Move it to i386 specific > files. > > Ack, but: > @@ -157,6 +157,10 @@ int kvm_arch_create(kvm_context_t kvm, unsigned long phys_mem_bytes, > if (r< 0) > return r; > > +#ifdef KVM_EXIT_TPR_ACCESS > + kvm_tpr_opt_setup(); > +#endif > + > Wierd indentation. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.