public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Ryota Ozaki <ozaki.ryota@gmail.com>
Cc: kvm@vger.kernel.org
Subject: Re: nice value is ignored on cpu time accounting of a guest?
Date: Tue, 20 Oct 2009 14:21:27 +0900	[thread overview]
Message-ID: <4ADD48D7.4090004@redhat.com> (raw)
In-Reply-To: <5e93dcec0910190246s7402417flfaadef0ddaf992ba@mail.gmail.com>

On 10/19/2009 06:46 PM, Ryota Ozaki wrote:
> Hi,
>
> I have a question on cputime accounting of a guest. CPU time of a
> guest is always
> accounted as 'user' time of cpustat even if nice value of the guest is
> higher than 0.
> Is there a reason to do so? I think the cpu time of the guest should
> be accounted
> into 'nice' as same as a normal process. Am I wrong?
>    

Hm, guest time is accounted separately, and added to user time in /proc 
(so tools that don't know about guest time can read it as user time).

Looks like we need to add a separate guest_nice, or get rid of guest 
time altogether.

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.


  reply	other threads:[~2009-10-20  5:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-19  9:46 nice value is ignored on cpu time accounting of a guest? Ryota Ozaki
2009-10-20  5:21 ` Avi Kivity [this message]
2009-10-20  7:06   ` Ryota Ozaki
2009-10-20  7:17     ` Avi Kivity
2009-10-20  7:27       ` Ryota Ozaki
2009-10-20  7:34         ` Avi Kivity
2009-10-20  7:38           ` Ryota Ozaki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ADD48D7.4090004@redhat.com \
    --to=avi@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=ozaki.ryota@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox