From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: nice value is ignored on cpu time accounting of a guest? Date: Tue, 20 Oct 2009 14:21:27 +0900 Message-ID: <4ADD48D7.4090004@redhat.com> References: <5e93dcec0910190246s7402417flfaadef0ddaf992ba@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Ryota Ozaki Return-path: Received: from mx1.redhat.com ([209.132.183.28]:52094 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750795AbZJTFV1 (ORCPT ); Tue, 20 Oct 2009 01:21:27 -0400 In-Reply-To: <5e93dcec0910190246s7402417flfaadef0ddaf992ba@mail.gmail.com> Sender: kvm-owner@vger.kernel.org List-ID: On 10/19/2009 06:46 PM, Ryota Ozaki wrote: > Hi, > > I have a question on cputime accounting of a guest. CPU time of a > guest is always > accounted as 'user' time of cpustat even if nice value of the guest is > higher than 0. > Is there a reason to do so? I think the cpu time of the guest should > be accounted > into 'nice' as same as a normal process. Am I wrong? > Hm, guest time is accounted separately, and added to user time in /proc (so tools that don't know about guest time can read it as user time). Looks like we need to add a separate guest_nice, or get rid of guest time altogether. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.