From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jan Kiszka <jan.kiszka@siemens.com>
Subject: Re: [PATCH v2 4/4] KVM: x86: Add VCPU substate for NMI states
Date: Tue, 20 Oct 2009 10:56:28 +0200
Message-ID: <4ADD7B3C.5080607@siemens.com>
References: <20091015170535.5076.91206.stgit@mchn012c.ww002.siemens.net> <20091015170536.5076.56790.stgit@mchn012c.ww002.siemens.net> <20091019203254.GD17781@amt.cnet> <20091019203950.GC8278@redhat.com> <4ADCF771.9070709@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: Gleb Natapov <gleb@redhat.com>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>
To: Avi Kivity <avi@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from thoth.sbs.de ([192.35.17.2]:16144 "EHLO thoth.sbs.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751458AbZJTI4i (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 20 Oct 2009 04:56:38 -0400
In-Reply-To: <4ADCF771.9070709@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Avi Kivity wrote:
> On 10/20/2009 05:39 AM, Gleb Natapov wrote:
>>> BTW, what happens to exceptions that fail to be delivered? Can't see
>>> where they are saved/restored across migration.
>>>
>>>      
>> The instruction that caused an exception will be re-executed after
>> migration and exception will be regenerated.
> 
> Except for debug exceptions (traps).
> 
>> But I think we should
>> migrate exception anyway for completeness.
>>    
> 
> Yes.

So save/restore kvm_vcpu_arch::exception? As another substate or as part
of a generalized NMI substate?

Jan

-- 
Siemens AG, Corporate Technology, CT SE 2
Corporate Competence Center Embedded Linux