From: Avi Kivity <avi@redhat.com>
To: Gleb Natapov <gleb@redhat.com>
Cc: Jan Kiszka <jan.kiszka@siemens.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>
Subject: Re: [PATCH v2 4/4] KVM: x86: Add VCPU substate for NMI states
Date: Tue, 20 Oct 2009 18:14:04 +0900 [thread overview]
Message-ID: <4ADD7F5C.9080906@redhat.com> (raw)
In-Reply-To: <20091020090809.GJ29477@redhat.com>
On 10/20/2009 06:08 PM, Gleb Natapov wrote:
> On Tue, Oct 20, 2009 at 06:06:36PM +0900, Avi Kivity wrote:
>
>> On 10/20/2009 05:56 PM, Jan Kiszka wrote:
>>
>>> So save/restore kvm_vcpu_arch::exception? As another substate or as part
>>> of a generalized NMI substate?
>>>
>> Yes. It's not part of an nmi substate, but both can be part of an
>> exception substate (but need to look at the docs vewy cawefuwy to
>> make sure we don't screw up again).
>>
>>
> What do you mean? How they can be both part of exception substate?
>
>
Sorry, nomenclature failure. We need NMI state, Interrupt state
(already provided), and pending exception state (which can be a fault or
a trap). There's also some extra state associated with pending debug
exceptions (maybe we can copy it into dr6).
We can either put all of these into one substate, or into separate
substates. I'm not sure which is best.
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
next prev parent reply other threads:[~2009-10-20 9:14 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-15 17:05 [PATCH v2 0/4] Extensible VCPU state IOCTL Jan Kiszka
2009-10-15 17:05 ` [PATCH v2 1/4] KVM: Reorder IOCTLs in main kvm.h Jan Kiszka
2009-10-15 17:05 ` [PATCH v2 4/4] KVM: x86: Add VCPU substate for NMI states Jan Kiszka
2009-10-19 20:32 ` Marcelo Tosatti
2009-10-19 20:39 ` Gleb Natapov
2009-10-19 23:34 ` Avi Kivity
2009-10-20 8:56 ` Jan Kiszka
2009-10-20 9:06 ` Avi Kivity
2009-10-20 9:08 ` Gleb Natapov
2009-10-20 9:14 ` Avi Kivity [this message]
2009-10-20 11:13 ` Marcelo Tosatti
2009-10-20 12:44 ` Gleb Natapov
2009-10-20 8:52 ` Jan Kiszka
2009-10-15 17:05 ` [PATCH v2 3/4] KVM: x86: Add support for KVM_GET/SET_VCPU_STATE Jan Kiszka
2009-10-15 17:05 ` [PATCH v2 2/4] KVM: Add unified KVM_GET/SET_VCPU_STATE IOCTL Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ADD7F5C.9080906@redhat.com \
--to=avi@redhat.com \
--cc=gleb@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox