From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: KVM: VMX: remove GUEST_CR3 write from vmx_vcpu_run
Date: Thu, 22 Oct 2009 10:06:23 +0300
Message-ID: <4AE0046F.70303@redhat.com>
References: <20091020123720.GA5679@amt.cnet> <4ADDB7CC.8040808@redhat.com> <20091020135928.GA6992@amt.cnet>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: kvm <kvm@vger.kernel.org>
To: Marcelo Tosatti <mtosatti@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:57878 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753484AbZJVHGW (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 22 Oct 2009 03:06:22 -0400
Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n9M76RVn019272
	for <kvm@vger.kernel.org>; Thu, 22 Oct 2009 03:06:27 -0400
In-Reply-To: <20091020135928.GA6992@amt.cnet>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 10/20/2009 04:59 PM, Marcelo Tosatti wrote:
>
>    
>> Nice.  Any reason why ept_load_pdptrs() couldn't go the same way?
>>      
> Its already protected by VCPU_EXREG_PDPTR caching, so it does not buy
> much.
>
> The advantage would symmetry to cr3.
>
>    

Yes, the PDPTRs fulfil exactly the same role as cr3, so the same rules 
should apply.

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.