kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Sheng Yang <sheng@linux.intel.com>
Cc: kvm@vger.kernel.org, Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: KVM: VMX: remove GUEST_CR3 write from vmx_vcpu_run
Date: Thu, 22 Oct 2009 09:48:46 +0200	[thread overview]
Message-ID: <4AE00E5E.7010605@redhat.com> (raw)
In-Reply-To: <200910221535.20614.sheng@linux.intel.com>

On 10/22/2009 09:35 AM, Sheng Yang wrote:
> On Tuesday 20 October 2009 20:37:20 Marcelo Tosatti wrote:
>    
>> GUEST_CR3 is updated via kvm_set_cr3 whenever CR3 value
>> changes.
>>      
> The description is not that accuracy... If CR3 value change in guest when EPT
> enabled, no VM Exit would happen, then no kvm_set_cr3...
>    

True, should be 'changed from userspace'.

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.


      reply	other threads:[~2009-10-22  7:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-20 12:37 KVM: VMX: remove GUEST_CR3 write from vmx_vcpu_run Marcelo Tosatti
2009-10-20 13:14 ` Avi Kivity
2009-10-20 13:59   ` Marcelo Tosatti
2009-10-22  7:06     ` Avi Kivity
2009-10-22  7:35 ` Sheng Yang
2009-10-22  7:48   ` Avi Kivity [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AE00E5E.7010605@redhat.com \
    --to=avi@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    --cc=sheng@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).