From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: KVM: VMX: remove GUEST_CR3 write from vmx_vcpu_run
Date: Thu, 22 Oct 2009 09:48:46 +0200
Message-ID: <4AE00E5E.7010605@redhat.com>
References: <20091020123720.GA5679@amt.cnet> <200910221535.20614.sheng@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: kvm@vger.kernel.org, Marcelo Tosatti <mtosatti@redhat.com>
To: Sheng Yang <sheng@linux.intel.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:44652 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751167AbZJVHsq (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 22 Oct 2009 03:48:46 -0400
In-Reply-To: <200910221535.20614.sheng@linux.intel.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 10/22/2009 09:35 AM, Sheng Yang wrote:
> On Tuesday 20 October 2009 20:37:20 Marcelo Tosatti wrote:
>    
>> GUEST_CR3 is updated via kvm_set_cr3 whenever CR3 value
>> changes.
>>      
> The description is not that accuracy... If CR3 value change in guest when EPT
> enabled, no VM Exit would happen, then no kvm_set_cr3...
>    

True, should be 'changed from userspace'.

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.