From: Avi Kivity <avi@redhat.com>
To: Alexander Graf <agraf@suse.de>
Cc: Carsten Otte <carsteno@de.ibm.com>,
qemu-devel <qemu-devel@nongnu.org>,
uli@suse.de, Carsten Otte <cotte@de.ibm.com>,
hare@suse.de, KVM list <kvm@vger.kernel.org>
Subject: Re: [PATCH 0/9] S390x KVM support
Date: Thu, 22 Oct 2009 11:53:18 +0200 [thread overview]
Message-ID: <4AE02B8E.6070202@redhat.com> (raw)
In-Reply-To: <98DC9E4C-7FFA-4F05-A2E8-0B5DF546891C@suse.de>
On 10/22/2009 11:11 AM, Alexander Graf wrote:
>> Doesn't this break backward compatibility by changing the structure?
>>
>> Best to put it after the union (and as a copy, so userspace that
>> expects the previous location still works). If you're reading it
>> from the kernel, also need a way to tell the kernel which copy to
>> read from.
>>
>> Also advertise with a KVM_CAP.
>
>
> I don't think we need to go through the hassle here. There is
> effectively no user of that code for now and the ABI is considered
> unstable.
At the very least we need a KVM_CAP so qemu knows to fail on older kernels.
>>
>> I'd also appreciate an explanation of what this is all about.
>
> Explanation in the code or explanation in an email reply?
email. I assume s390 hackers would understand why the psw needs to be
exposed to qemu on every exit. This is mostly for my personal interest.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2009-10-22 9:53 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1255963059-10298-1-git-send-email-agraf@suse.de>
[not found] ` <4ADDE7E3.9090601@de.ibm.com>
2009-10-22 9:08 ` [PATCH 0/9] S390x KVM support Avi Kivity
2009-10-22 9:11 ` Alexander Graf
2009-10-22 9:53 ` Avi Kivity [this message]
2009-10-22 9:55 ` Alexander Graf
2009-10-22 9:58 ` Alexander Graf
2009-10-22 10:03 ` Avi Kivity
2009-10-22 10:13 ` Alexander Graf
2009-10-22 10:22 ` Carsten Otte
2009-10-22 10:28 ` Avi Kivity
2009-10-22 10:43 ` Carsten Otte
2009-10-22 10:49 ` Avi Kivity
2009-10-22 11:10 ` Carsten Otte
2009-11-02 20:23 ` Alexander Graf
2009-11-03 8:55 ` Avi Kivity
2009-10-22 9:18 ` Carsten Otte
2009-10-22 10:02 ` Avi Kivity
2009-10-22 10:20 ` Carsten Otte
2009-10-22 10:29 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AE02B8E.6070202@redhat.com \
--to=avi@redhat.com \
--cc=agraf@suse.de \
--cc=carsteno@de.ibm.com \
--cc=cotte@de.ibm.com \
--cc=hare@suse.de \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
--cc=uli@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox