From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Otte Subject: Re: [PATCH 0/9] S390x KVM support Date: Thu, 22 Oct 2009 12:20:00 +0200 Message-ID: <4AE031D0.50002@de.ibm.com> References: <1255963059-10298-1-git-send-email-agraf@suse.de> <4ADDE7E3.9090601@de.ibm.com> <4AE0210D.9020409@redhat.com> <4AE02379.4090603@de.ibm.com> <4AE02DA1.8090500@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Alexander Graf , qemu-devel , uli@suse.de, Carsten Otte , hare@suse.de, KVM list To: Avi Kivity Return-path: Received: from mtagate2.de.ibm.com ([195.212.17.162]:50406 "EHLO mtagate2.de.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752449AbZJVKTp (ORCPT ); Thu, 22 Oct 2009 06:19:45 -0400 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate2.de.ibm.com (8.13.1/8.13.1) with ESMTP id n9MAJn8X011160 for ; Thu, 22 Oct 2009 10:19:49 GMT Received: from d12av03.megacenter.de.ibm.com (d12av03.megacenter.de.ibm.com [9.149.165.213]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id n9MAJnbF3059842 for ; Thu, 22 Oct 2009 12:19:49 +0200 Received: from d12av03.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av03.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n9MAJmhB004698 for ; Thu, 22 Oct 2009 12:19:49 +0200 In-Reply-To: <4AE02DA1.8090500@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Avi Kivity wrote: > gdb is hardly performance critical. Is that the only reason for the > change? Right, gdb is not performance critical. gdb is the reason for moving it out of the union, performance is the reason for having it in kvm_run at all. There's only more reason to it: with a little tweaking in kuli, we'll be able to get rid of KVM_S390_SET_INITIAL_PSW ioctl with this change. That removes one oddity that makes us different from other platforms.