Re: [PATCH] Enable 32bit dirty log pointers on 64bit host

[Avi Kivity <avi@redhat.com>]

On 10/21/2009 04:08 PM, Alexander Graf wrote:
> From: Arnd Bergmann<arnd@arndb.de>
>
> With big endian userspace, we can't quite figure out if a pointer
> is 32 bit (shifted>>  32) or 64 bit when we read a 64 bit pointer.
>
> This is what happens with dirty logging. To get the pointer interpreted
> correctly, we thus need Arnd's patch to implement a compat layer for
> the ioctl:
>
> A better way to do this is to add a separate compat_ioctl() method that
> converts this for you.
>
> From: Arnd Bergmann<arnd@arndb.de>
> Signed-off-by: Arnd Bergmann<arnd@arndb.de>
> Acked-by: Alexander Graf<agraf@suse.de>
>
>    

If you send someone's patch, you need to sign this off.  That says you 
are legally allowed to send it along.

Ack means "I have a say in this area and it looks good to me", you add 
it when someone else is doing the sending.

> Changes from Arnd's example version:
>    

This goes double when changing the patch.

With all the legalese out of the way, the actual code looks good.

-- 
error compiling committee.c: too many arguments to function