From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] Enable 32bit dirty log pointers on 64bit host Date: Thu, 22 Oct 2009 12:23:35 +0200 Message-ID: <4AE032A7.3060804@redhat.com> References: <1256134109-14292-1-git-send-email-agraf@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, kvm-ppc , Arnd Bergmann To: Alexander Graf Return-path: Received: from mx1.redhat.com ([209.132.183.28]:9926 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752318AbZJVKXk (ORCPT ); Thu, 22 Oct 2009 06:23:40 -0400 In-Reply-To: <1256134109-14292-1-git-send-email-agraf@suse.de> Sender: kvm-owner@vger.kernel.org List-ID: On 10/21/2009 04:08 PM, Alexander Graf wrote: > From: Arnd Bergmann > > With big endian userspace, we can't quite figure out if a pointer > is 32 bit (shifted>> 32) or 64 bit when we read a 64 bit pointer. > > This is what happens with dirty logging. To get the pointer interpreted > correctly, we thus need Arnd's patch to implement a compat layer for > the ioctl: > > A better way to do this is to add a separate compat_ioctl() method that > converts this for you. > > From: Arnd Bergmann > Signed-off-by: Arnd Bergmann > Acked-by: Alexander Graf > > If you send someone's patch, you need to sign this off. That says you are legally allowed to send it along. Ack means "I have a say in this area and it looks good to me", you add it when someone else is doing the sending. > Changes from Arnd's example version: > This goes double when changing the patch. With all the legalese out of the way, the actual code looks good. -- error compiling committee.c: too many arguments to function