From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 0/9] S390x KVM support Date: Thu, 22 Oct 2009 12:29:57 +0200 Message-ID: <4AE03425.30603@redhat.com> References: <1255963059-10298-1-git-send-email-agraf@suse.de> <4ADDE7E3.9090601@de.ibm.com> <4AE0210D.9020409@redhat.com> <4AE02379.4090603@de.ibm.com> <4AE02DA1.8090500@redhat.com> <4AE031D0.50002@de.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Alexander Graf , qemu-devel , uli@suse.de, Carsten Otte , hare@suse.de, KVM list To: Carsten Otte Return-path: Received: from mx1.redhat.com ([209.132.183.28]:61686 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753203AbZJVKaG (ORCPT ); Thu, 22 Oct 2009 06:30:06 -0400 In-Reply-To: <4AE031D0.50002@de.ibm.com> Sender: kvm-owner@vger.kernel.org List-ID: On 10/22/2009 12:20 PM, Carsten Otte wrote: > Avi Kivity wrote: >> gdb is hardly performance critical. Is that the only reason for the >> change? > Right, gdb is not performance critical. gdb is the reason for moving > it out of the union, performance is the reason for having it in > kvm_run at all. > There's only more reason to it: with a little tweaking in kuli, we'll > be able to get rid of KVM_S390_SET_INITIAL_PSW ioctl with this change. > That removes one oddity that makes us different from other platforms. In fact qemu/x86 does a KVM_SET_SREGS (which updates pc) on reset. -- error compiling committee.c: too many arguments to function