From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] Enable 32bit dirty log pointers on 64bit host Date: Thu, 22 Oct 2009 12:32:17 +0200 Message-ID: <4AE034B1.4000101@redhat.com> References: <1256134109-14292-1-git-send-email-agraf@suse.de> <4AE032A7.3060804@redhat.com> <03CB8BC3-B33F-4253-A259-A1517A099698@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kvm-ppc , Arnd Bergmann To: Alexander Graf Return-path: In-Reply-To: <03CB8BC3-B33F-4253-A259-A1517A099698-l3A5Bk7waGM@public.gmane.org> Sender: kvm-ppc-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: kvm.vger.kernel.org On 10/22/2009 12:25 PM, Alexander Graf wrote: >> If you send someone's patch, you need to sign this off. That says >> you are legally allowed to send it along. >> >> Ack means "I have a say in this area and it looks good to me", you >> add it when someone else is doing the sending. > > > Ok, so is it still a From: Arnd then? Is it still signed-off by Arnd > even though I change it? Yes. Most kvm patches are From: other people, I just add my signoff (and definitely don't remote theirs). Whether to change From: depends on the changes. If you rewrite the patch, it's From: you. If you just fix a couple of bugs, you generally leave From: alone. > Is there a Based-on-patch-by: tag? :-) You can always say "Based on initial patch from ...". -- error compiling committee.c: too many arguments to function