From: Avi Kivity <avi@redhat.com>
To: Max Laier <max@love2party.net>
Cc: Marcelo Tosatti <mtosatti@redhat.com>, kvm <kvm@vger.kernel.org>
Subject: Re: KVM: VMX: flush TLB with INVEPT on cpu migration
Date: Thu, 22 Oct 2009 17:10:51 +0200 [thread overview]
Message-ID: <4AE075FB.3090605@redhat.com> (raw)
In-Reply-To: <200910210318.27624.max@love2party.net>
On 10/21/2009 03:18 AM, Max Laier wrote:
> On Friday 02 October 2009 00:16:58 you wrote:
>
>> It is possible that stale EPTP-tagged mappings are used, if a
>> vcpu migrates to a different pcpu.
>>
>> Set KVM_REQ_TLB_FLUSH in vmx_vcpu_load, when switching pcpus, which
>> will invalidate both VPID and EPT mappings on the next vm-entry.
>>
> Thank you - I was at the brink of a nervous break-down before discovering
> this. Maybe it would help for the future to add a comment to
> ept_misconfig_inspect_spte that explains that this might be caused by out of
> sync tlbs, too (esp. when it doesn't show an apparent cause of the misconfig)
>
In fact ept_misconfig_inspect_spte() was added in order to track down
this bug, so it will probably be removed in the future.
--
error compiling committee.c: too many arguments to function
prev parent reply other threads:[~2009-10-22 15:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-01 22:16 KVM: VMX: flush TLB with INVEPT on cpu migration Marcelo Tosatti
2009-10-02 20:56 ` Ram Pai
2009-10-21 1:18 ` Max Laier
2009-10-22 15:10 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AE075FB.3090605@redhat.com \
--to=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=max@love2party.net \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).