From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 1/2] kvm-kmod: Use the main development tree of kvm as Linux submodule Date: Thu, 22 Oct 2009 18:35:50 +0200 Message-ID: <4AE089E6.4000909@redhat.com> References: <1256040699-27468-1-git-send-email-wolfgang.mauerer@siemens.com> <4AE076FA.3090205@redhat.com> <4AE084B8.2050902@siemens.com> <4AE085A0.7030300@redhat.com> <4AE0876A.5060005@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: "kvm@vger.kernel.org" , "Kiszka, Jan" To: Wolfgang Mauerer Return-path: Received: from mx1.redhat.com ([209.132.183.28]:15034 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753179AbZJVQft (ORCPT ); Thu, 22 Oct 2009 12:35:49 -0400 In-Reply-To: <4AE0876A.5060005@siemens.com> Sender: kvm-owner@vger.kernel.org List-ID: On 10/22/2009 06:25 PM, Wolfgang Mauerer wrote: > > >>> consider that you clone kvm-kmod from your repo and >>> then create local clones from which you do the build. If you don't >>> happen to have /path/to/my/kvm-kmod/../kvm, then the relative >>> submodule URL won't work, but the absolute one will. >>> >>> >> Typically you create the clones using 'git submodule init&& git >> submodule update', not clone them manually. >> > But that refers to linux-2.6/, I suppose, while I was talking > about kvm-kmod. > Oh. If you create local clones for kvm-kmod.git, also create local clones for kvm.git. I'd expect the submodule to use the local clone (for example, if I don't have access to the external hosting). > that's certainly true. I'd say it's a matter of taste, so > I'll just add a hint about .git/config to the README and leave > .gitmodules unmolested in the future. > Relative paths are a requirement for http: access, which is needed from certain corporate firewalls, so it will have to stay. -- error compiling committee.c: too many arguments to function