Re: [PATCH 19/27] Export symbols for KVM module

Alexander Graf
2009-10-29T02:53:03Z

On 29.10.2009, at 03:46, Benjamin Herrenschmidt wrote:

> On Wed, 2009-10-21 at 17:03 +0200, Alexander Graf wrote:
>> We want to be able to build KVM as a module. To enable us doing so,
>> we
>> need some more exports from core Linux parts.
>>
>> This patch exports all functions and variables that are required
>> for KVM.
>>
>> Signed-off-by: Alexander Graf <agraf@suse.de>
>
> Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> ---
>
> Quick nit:
>
>> u16 mmu_slb_size = 64;
>> +EXPORT_SYMBOL_GPL(mmu_slb_size);
>
> This value might change when doing a partition migration between a
> POWER6 and a POWER7 so KVM might need to be extra careful...

It shouldn't be an issue.

The SLB size for the guest and the SLB size we project things on to on
the host are completely independent. So when we migrate, only the
guest information is transferred to the new host which then uses its
own SLB information to regenerate the shadow entries.

So everything's fine :-)

Alex