From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH 4/4] KVM: x86: Add VCPU substate for NMI states Date: Mon, 26 Oct 2009 08:40:32 +0100 Message-ID: <4AE55270.1000500@web.de> References: <20091013160647.27006.58598.stgit@mchn012c.ww002.siemens.net> <20091013160648.27006.29041.stgit@mchn012c.ww002.siemens.net> <4AD6D8B6.3050003@redhat.com> <4AD6E9E1.1040704@siemens.com> <4AD6EB63.9030306@redhat.com> <4AD7070D.7070108@siemens.com> <4AE44E88.4000603@redhat.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig923FA1386AC097267A4BF4AD" Cc: Marcelo Tosatti , "kvm@vger.kernel.org" To: Avi Kivity Return-path: Received: from fmmailgate02.web.de ([217.72.192.227]:49619 "EHLO fmmailgate02.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754900AbZJZHk3 (ORCPT ); Mon, 26 Oct 2009 03:40:29 -0400 In-Reply-To: <4AE44E88.4000603@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig923FA1386AC097267A4BF4AD Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Avi Kivity wrote: > On 10/15/2009 01:27 PM, Jan Kiszka wrote: >>> Perhaps it makes sense to query about individual states, including >>> existing ones? That will allow us to deprecate and then phase out >>> broken states. It's probably not worth it. >>> =20 >> You may do this already with the given design: Set up a VCPU, then iss= ue >> KVM_GET_VCPU_STATE on the substate in question. You will either get an= >> error code or 0 if the substate is supported. At least no additional >> kernel code required. >> =20 >=20 > No, if some code requires a feature, we don't want to set up a guest an= d=20 > a vcpu and issue dummy commands in order to find out if we can actually= =20 > run that code. >=20 > Feature discovery needs to be a 'system ioctl' in the words of=20 > Documentation/kvm/api.txt. >=20 OK, added some system IOCTL 'KVM_GET_VCPU_STATE_LIST' to my to-do list. Jan --------------enig923FA1386AC097267A4BF4AD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAkrlUnAACgkQitSsb3rl5xTWEACgnGzrBYBOfkobN9L64lS3/iuz 17EAoNj5cKH2HN2yGMweSYGDnyDN4oGV =3S4u -----END PGP SIGNATURE----- --------------enig923FA1386AC097267A4BF4AD--