KVM: MMU: update invlpg handler comment

public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed

* KVM: MMU: update invlpg handler comment
@ 2009-10-26 18:50 Marcelo Tosatti
  2009-10-27  9:59 ` Avi Kivity
  0 siblings, 1 reply; 2+ messages in thread
From: Marcelo Tosatti @ 2009-10-26 18:50 UTC (permalink / raw)
  To: Avi Kivity; +Cc: kvm


Large page translations are always synchronized (either in level 3 
or level 2), so its not necessary to properly deal with them
in the invlpg handler.

Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>

Index: b/arch/x86/kvm/paging_tmpl.h
===================================================================
--- a/arch/x86/kvm/paging_tmpl.h
+++ b/arch/x86/kvm/paging_tmpl.h
@@ -467,7 +467,6 @@ static void FNAME(invlpg)(struct kvm_vcp
 		level = iterator.level;
 		sptep = iterator.sptep;
 
-		/* FIXME: properly handle invlpg on large guest pages */
 		if (level == PT_PAGE_TABLE_LEVEL  ||
 		    ((level == PT_DIRECTORY_LEVEL && is_large_pte(*sptep))) ||
 		    ((level == PT_PDPE_LEVEL && is_large_pte(*sptep)))) {

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: KVM: MMU: update invlpg handler comment
  2009-10-26 18:50 KVM: MMU: update invlpg handler comment Marcelo Tosatti
@ 2009-10-27  9:59 ` Avi Kivity
  0 siblings, 0 replies; 2+ messages in thread
From: Avi Kivity @ 2009-10-27  9:59 UTC (permalink / raw)
  To: Marcelo Tosatti; +Cc: kvm

On 10/26/2009 08:50 PM, Marcelo Tosatti wrote:
> Large page translations are always synchronized (either in level 3
> or level 2), so its not necessary to properly deal with them
> in the invlpg handler.
>    

Applied, thanks.

-- 
error compiling committee.c: too many arguments to function


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-10-27  9:59 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-10-26 18:50 KVM: MMU: update invlpg handler comment Marcelo Tosatti
2009-10-27  9:59 ` Avi Kivity

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox