Re: BUG with Win7 and user-return-notifier

Avi Kivity
2009-10-29T16:52:37Z

On 10/29/2009 06:14 PM, Jan Kiszka wrote:
>
> OK, EFER is a globally shared msr. But there still needs to be a
> consensus on the slot id used for guest_msrs and
> shared_msrs_global.msrs, right? move_msr_up works per-vcpu and is
> obviously decoupled...
>
>

move_msr_up() moves a shared_msr_entry, which contains an index into the
shared_msrs_global structure. Double indirection:

msr_index = kvm_shared_msrs_global.msrs[vmx->guest_msrs[index].index].msr

So guest_msrs can be rearranged at will. Except for your oops.

--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.