From: Avi Kivity <avi@redhat.com>
To: Chris Lalancette <clalance@redhat.com>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH 0/5]: Fix kdump under KVM
Date: Thu, 29 Oct 2009 12:15:59 +0200 [thread overview]
Message-ID: <4AE96B5F.7060106@redhat.com> (raw)
In-Reply-To: <4AE953A6.1000204@redhat.com>
On 10/29/2009 10:34 AM, Chris Lalancette wrote:
>
> I'm starting to take a look at this. While this may be a generically useful
> cleanup, it occurs to me that even if we call "set_irq" from the hrtimer
> callback, we still have to do the "kick_vcpus" type thing. Otherwise, we still
> have the problem where if all vcpus are idle, none of them will be doing
> vcpu_run anytime soon to actually inject the interrupt into the guest.
>
> Or did I mis-understand what you are proposing?
>
The pic and ioapic code will kick vcpus that they deliver interrupts to,
that's the natural order of things. It was the kick from the timer
(which is only connected indirectly to vcpus via the pic/ioapic) which
is hacky and special.
As a bonus, if the interrupt is masked, no vcpus will be kicked.
--
error compiling committee.c: too many arguments to function
prev parent reply other threads:[~2009-10-29 10:15 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-27 16:41 [PATCH 0/5]: Fix kdump under KVM Chris Lalancette
2009-10-27 16:41 ` [PATCH 1/5] Fix up some comments around the source tree Chris Lalancette
2009-10-27 16:41 ` [PATCH 2/5] Remove KVM_REQ_PENDING_TIMER Chris Lalancette
2009-10-27 16:41 ` [PATCH 3/5] Remove references to VCPU in i8254 Chris Lalancette
2009-10-27 16:41 ` [PATCH 4/5] Remove timer.c Chris Lalancette
2009-10-27 16:41 ` [PATCH 5/5] Fix kdump under KVM Chris Lalancette
2009-10-27 17:42 ` Marcelo Tosatti
2009-10-28 10:21 ` Chris Lalancette
2009-10-28 12:41 ` Marcelo Tosatti
2009-10-30 12:23 ` Chris Lalancette
2009-10-30 13:07 ` Marcelo Tosatti
2009-10-30 15:28 ` Chris Lalancette
2009-10-30 18:03 ` David S. Ahern
2009-10-30 22:21 ` Marcelo Tosatti
2009-10-30 22:19 ` Marcelo Tosatti
2009-11-01 15:21 ` Avi Kivity
2009-11-02 13:22 ` Chris Lalancette
2009-11-02 13:30 ` Avi Kivity
2009-10-28 9:59 ` [PATCH 0/5]: " Avi Kivity
2009-10-28 10:13 ` Chris Lalancette
2009-10-28 10:31 ` Avi Kivity
2009-10-29 8:34 ` Chris Lalancette
2009-10-29 10:15 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AE96B5F.7060106@redhat.com \
--to=avi@redhat.com \
--cc=clalance@redhat.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).