From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 0/5]: Fix kdump under KVM Date: Thu, 29 Oct 2009 12:15:59 +0200 Message-ID: <4AE96B5F.7060106@redhat.com> References: <1256661667-9298-1-git-send-email-clalance@redhat.com> <4AE81617.6060406@redhat.com> <4AE81959.2000801@redhat.com> <4AE81D87.1030709@redhat.com> <4AE953A6.1000204@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Chris Lalancette Return-path: Received: from mx1.redhat.com ([209.132.183.28]:62854 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753884AbZJ2KP4 (ORCPT ); Thu, 29 Oct 2009 06:15:56 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n9TAG1k7021858 for ; Thu, 29 Oct 2009 06:16:01 -0400 In-Reply-To: <4AE953A6.1000204@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 10/29/2009 10:34 AM, Chris Lalancette wrote: > > I'm starting to take a look at this. While this may be a generically useful > cleanup, it occurs to me that even if we call "set_irq" from the hrtimer > callback, we still have to do the "kick_vcpus" type thing. Otherwise, we still > have the problem where if all vcpus are idle, none of them will be doing > vcpu_run anytime soon to actually inject the interrupt into the guest. > > Or did I mis-understand what you are proposing? > The pic and ioapic code will kick vcpus that they deliver interrupts to, that's the natural order of things. It was the kick from the timer (which is only connected indirectly to vcpus via the pic/ioapic) which is hacky and special. As a bonus, if the interrupt is masked, no vcpus will be kicked. -- error compiling committee.c: too many arguments to function