From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: qemu-kvm-0.11 regression, crashes on older guests with virtio network Date: Thu, 29 Oct 2009 16:38:22 +0200 Message-ID: <4AE9A8DE.1070609@redhat.com> References: <1256807803.10825.39.camel@blaa> <20091029122334.GB3478@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Mark McLoughlin , Dustin Kirkland , qemu-devel@nongnu.org, kvm@vger.kernel.org, Anthony Liguori , Scott Tsai To: "Michael S. Tsirkin" Return-path: Received: from mx1.redhat.com ([209.132.183.28]:43735 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752966AbZJ2Oil (ORCPT ); Thu, 29 Oct 2009 10:38:41 -0400 In-Reply-To: <20091029122334.GB3478@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 10/29/2009 02:23 PM, Michael S. Tsirkin wrote: > On Thu, Oct 29, 2009 at 09:16:43AM +0000, Mark McLoughlin wrote: > >> I agree we shouldn't exit in this scenario >> > virtio in qemu generally seems to handle guest errors > by calling exit(2). This probably makes it easier to notice > the problems, but is likely not the right thing to do. > Right, the thinking was the guest is shooting itself in the foot and hitting, but a guest can delegate control of a device to unprivileged code (for example device assignment in kvm), which would allow this unprivileged code to kill the guest. -- error compiling committee.c: too many arguments to function