From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: BUG with Win7 and user-return-notifier
Date: Thu, 29 Oct 2009 18:52:33 +0200
Message-ID: <4AE9C851.5050708@redhat.com>
References: <4AE6ED18.9040901@siemens.com> <4AE6F17C.1070403@redhat.com> <4AE6F1EE.5090207@siemens.com> <4AE6F4A3.3050903@redhat.com> <4AE6F4C4.3000802@redhat.com> <4AE7FE3B.2070802@redhat.com> <4AE84EB4.1010603@siemens.com> <4AE86AA0.1060802@redhat.com> <4AE8AC20.50506@web.de> <4AE9462E.5050409@redhat.com> <4AE9BDD1.3050001@siemens.com> <4AE9BF77.8010700@siemens.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: kvm-devel <kvm@vger.kernel.org>
To: Jan Kiszka <jan.kiszka@siemens.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:22823 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1755638AbZJ2Qwh (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 29 Oct 2009 12:52:37 -0400
In-Reply-To: <4AE9BF77.8010700@siemens.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 10/29/2009 06:14 PM, Jan Kiszka wrote:
>
> OK, EFER is a globally shared msr. But there still needs to be a
> consensus on the slot id used for guest_msrs and
> shared_msrs_global.msrs, right? move_msr_up works per-vcpu and is
> obviously decoupled...
>
>    

move_msr_up() moves a shared_msr_entry, which contains an index into the 
shared_msrs_global structure.  Double indirection:

   msr_index = kvm_shared_msrs_global.msrs[vmx->guest_msrs[index].index].msr

So guest_msrs can be rearranged at will.  Except for your oops.

-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.