Re: [PATCH v2] fix qemu-kvm sigsegv at exit

[Avi Kivity <avi@redhat.com>]

On 10/29/2009 12:38 AM, Marcelo Tosatti wrote:
>
>> This will miss an event at the very beginning of the loop (powerdown
>> requested before we had a chance to spin up?).  I think it should be
>> fine since there will be a pending signal which will break us out of
>> kvm_cpu_exec() before it has a chance to do anything (i.e. spin in the
>> guest).
>>
>> So, I think it's fine, but please double check the above.
>>      
> That can happen but only with the unpatched version, where
> kvm_main_loop_wait eats the signal, sets env->stopped = 1,
> and proceeds to kvm_cpu_exec.
> With the patch, this is not the case.
>
> As before, the signal sender will send an IPI with smp_send_reschedule
> (and vcpu_enter_guest checks sigpending after disabling interrupts).
>    

Fair enough, double bugfix; applied, thanks.

-- 
error compiling committee.c: too many arguments to function