From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: error while loading state for instance 0x0 of device 'kvmclock' Date: Mon, 02 Nov 2009 11:28:38 +0100 Message-ID: <4AEEB456.1000006@siemens.com> References: <4AEE99F5.5000509@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Cc: kvm To: Marcelo Tosatti , Glauber Costa Return-path: Received: from thoth.sbs.de ([192.35.17.2]:19925 "EHLO thoth.sbs.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754213AbZKBK2r (ORCPT ); Mon, 2 Nov 2009 05:28:47 -0500 In-Reply-To: <4AEE99F5.5000509@web.de> Sender: kvm-owner@vger.kernel.org List-ID: Jan Kiszka wrote: > Hi, > > current qemu-kvm.git gives me the message "qemu: warning: error while > loading state for instance 0x0 of device 'kvmclock'" when I run a simple > "savevm" followed by a "loadvm 1". What's broken here? OK, this is due to "KVM: add flags to kvm_clock_data" (958b0c5497): the flags field is not cleared on KVM_SET_CLOCK. Will post a fix. But the above kernel commit is also broken: KVM_GET_CLOCK checks uninitialized user_ns.flags (probably instead of the user's value). This raises the question if the caller of KVM_GET_CLOCK is also supposed to pass kvm_clock_data with flags cleared down to the kernel. Could someone clarify this so I could fix it accordingly? Jan -- Siemens AG, Corporate Technology, CT SE 2 Corporate Competence Center Embedded Linux