Re: [PULL REQUEST] merge latest upstream qemu networking bits

Avi Kivity
2009-11-02T12:04:45Z

On 11/02/2009 01:57 PM, Mark McLoughlin wrote:
> On Mon, 2009-11-02 at 12:36 +0200, Avi Kivity wrote:
>
>> On 10/28/2009 04:19 PM, Mark McLoughlin wrote:
>>
>
>>> The most notable thing here is that all our networking changes are now
>>> upstream - i.e. there are no longer qemu-kvm specific changes to
>>> net.[ch], net-queue.[ch], savevm.c and hw/virtio-net.c
>>>
>>> This has resulted in one intentional regression - in order to use GSO,
>>> you must now use '-netdev tap' rather than '-net tap'. We could continue
>>> to support the latter, but it's never going upstream so we may as well
>>> drop it now.
>>>
>>> Another regression is that virtio-net loses it's MAC address, but I've
>>> just sent a fix for that to qemu-devel.
>>>
>>>
>> What does this mean? It loses the ability to set it?
>>
> Yep:
>
> http://git.savannah.gnu.org/cgit/qemu.git/commit/?id=3cbe04c44
>

I cherry-picked this commit to avoid the regression.

--
error compiling committee.c: too many arguments to function