From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PULL REQUEST] merge latest upstream qemu networking bits Date: Mon, 02 Nov 2009 14:04:48 +0200 Message-ID: <4AEECAE0.4070507@redhat.com> References: <1256739546.5105.48.camel@blaa> <4AEEB62E.4090206@redhat.com> <1257163025.3061.10.camel@blaa> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm To: Mark McLoughlin Return-path: Received: from mx1.redhat.com ([209.132.183.28]:64686 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754452AbZKBMEp (ORCPT ); Mon, 2 Nov 2009 07:04:45 -0500 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id nA2C4oPL028873 for ; Mon, 2 Nov 2009 07:04:50 -0500 In-Reply-To: <1257163025.3061.10.camel@blaa> Sender: kvm-owner@vger.kernel.org List-ID: On 11/02/2009 01:57 PM, Mark McLoughlin wrote: > On Mon, 2009-11-02 at 12:36 +0200, Avi Kivity wrote: > >> On 10/28/2009 04:19 PM, Mark McLoughlin wrote: >> > >>> The most notable thing here is that all our networking changes are now >>> upstream - i.e. there are no longer qemu-kvm specific changes to >>> net.[ch], net-queue.[ch], savevm.c and hw/virtio-net.c >>> >>> This has resulted in one intentional regression - in order to use GSO, >>> you must now use '-netdev tap' rather than '-net tap'. We could continue >>> to support the latter, but it's never going upstream so we may as well >>> drop it now. >>> >>> Another regression is that virtio-net loses it's MAC address, but I've >>> just sent a fix for that to qemu-devel. >>> >>> >> What does this mean? It loses the ability to set it? >> > Yep: > > http://git.savannah.gnu.org/cgit/qemu.git/commit/?id=3cbe04c44 > I cherry-picked this commit to avoid the regression. -- error compiling committee.c: too many arguments to function