Re: [PATCHv4 1/6] qemu/virtio: move features to an inline function

[Anthony Liguori <anthony@codemonkey.ws>]

Michael S. Tsirkin wrote:
> devices should have the final say over which virtio features they
> support. E.g. indirect entries may or may not make sense in the context
> of virtio-console. In particular, for vhost, we do not want to report to
> guest bits not supported by kernel backend.  Move the common bits from
> virtio-pci to an inline function and let each device call it.
>
> No functional changes.
>   

This is a layering violation.  There are transport specific features and 
device specific features.  The virtio-net device should have no 
knowledge or nack'ing ability for transport features.

If you need to change transport features, it suggests you're modeling 
things incorrectly and should be supplying an alternative transport 
implementation.

Regards,

Anthony Liguori