From: Jan Kiszka <jan.kiszka@web.de>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: kvm@vger.kernel.org, gleb@redhat.com, jan.kiszka@siemens.com,
joerg.roedel@amd.com
Subject: Re: [patch 1/2] KVM: x86: handle double and triple faults for every exception
Date: Wed, 11 Nov 2009 21:07:08 +0100 [thread overview]
Message-ID: <4AFB196C.7010302@web.de> (raw)
In-Reply-To: <20091111193837.115825934@localhost.localdomain>
[-- Attachment #1: Type: text/plain, Size: 877 bytes --]
Marcelo Tosatti wrote:
> From: Joerg Roedel <joerg.roedel@amd.com>
>
> The current KVM x86 exception code handles double and triple faults only for
> page fault exceptions. This patch extends this detection for every exception
> that gets queued for the guest.
>
> Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
> CC: Jan Kiszka <jan.kiszka@web.de>
For a moment I felt like I was time traveling - back in '08. :)
Reading the archive I noticed that someone posted a fix-up for this patch:
http://permalink.gmane.org/gmane.comp.emulators.kvm.devel/16931
Why don't we need this anymore?
Moreover, are we sure to not regress /wrt to the cases that shall be
handled serially? So far they should have triggered the WARN_ON, right?
But maybe that went through unnoticed, and the guest was simply happy to
not have triggered a triple fault...
Jan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 257 bytes --]
next prev parent reply other threads:[~2009-11-11 20:10 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-11 19:29 [patch 0/2] Handle multiple exceptions (fixes Win2003 reboot by triple fault) Marcelo Tosatti
2009-11-11 19:29 ` [patch 1/2] KVM: x86: handle double and triple faults for every exception Marcelo Tosatti
2009-11-11 20:07 ` Jan Kiszka [this message]
2009-11-11 20:41 ` Marcelo Tosatti
2009-11-11 21:02 ` Jan Kiszka
2009-11-11 21:40 ` Marcelo Tosatti
2009-11-15 12:30 ` Avi Kivity
2009-11-12 12:26 ` Gleb Natapov
2009-11-15 12:41 ` Avi Kivity
2009-11-15 12:51 ` Gleb Natapov
2009-11-15 13:11 ` Avi Kivity
2009-11-15 14:29 ` Jan Kiszka
2009-11-15 14:34 ` Avi Kivity
2009-11-15 14:36 ` Jan Kiszka
2009-11-11 19:29 ` [patch 2/2] KVM: x86: raise TSS exception for NULL CS and SS segments Marcelo Tosatti
2009-11-12 12:21 ` [patch 0/2] Handle multiple exceptions (fixes Win2003 reboot by triple fault) Gleb Natapov
2009-11-12 12:41 ` Jan Kiszka
2009-11-12 13:05 ` Gleb Natapov
2009-11-15 12:54 ` Avi Kivity
2009-11-19 15:54 ` Gleb Natapov
2009-11-20 15:55 ` Ryan Harper
2009-11-23 16:52 ` Marcelo Tosatti
2009-11-25 9:55 ` Avi Kivity
2009-11-25 13:03 ` Marcelo Tosatti
2009-11-12 16:07 ` Marcelo Tosatti
2009-11-12 18:03 ` Gleb Natapov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AFB196C.7010302@web.de \
--to=jan.kiszka@web.de \
--cc=gleb@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=joerg.roedel@amd.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox