From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [patch 1/2] KVM: x86: handle double and triple faults for every exception Date: Wed, 11 Nov 2009 21:07:08 +0100 Message-ID: <4AFB196C.7010302@web.de> References: <20091111192947.348198723@localhost.localdomain> <20091111193837.115825934@localhost.localdomain> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig5446E6CF1D9471C846BD74EC" Cc: kvm@vger.kernel.org, gleb@redhat.com, jan.kiszka@siemens.com, joerg.roedel@amd.com To: Marcelo Tosatti Return-path: Received: from fmmailgate01.web.de ([217.72.192.221]:45505 "EHLO fmmailgate01.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752413AbZKKUKa (ORCPT ); Wed, 11 Nov 2009 15:10:30 -0500 In-Reply-To: <20091111193837.115825934@localhost.localdomain> Sender: kvm-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig5446E6CF1D9471C846BD74EC Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Marcelo Tosatti wrote: > From: Joerg Roedel >=20 > The current KVM x86 exception code handles double and triple faults onl= y for > page fault exceptions. This patch extends this detection for every exce= ption > that gets queued for the guest. >=20 > Signed-off-by: Joerg Roedel > CC: Jan Kiszka For a moment I felt like I was time traveling - back in '08. :) Reading the archive I noticed that someone posted a fix-up for this patch= : http://permalink.gmane.org/gmane.comp.emulators.kvm.devel/16931 Why don't we need this anymore? Moreover, are we sure to not regress /wrt to the cases that shall be handled serially? So far they should have triggered the WARN_ON, right? But maybe that went through unnoticed, and the guest was simply happy to not have triggered a triple fault... Jan --------------enig5446E6CF1D9471C846BD74EC Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAkr7GXQACgkQitSsb3rl5xSMBwCfY/BxHYdk2bBLQIi7dpJbFBhN bFsAoLoti5zMJMxM/N6C9SrslN9Piusb =1OWY -----END PGP SIGNATURE----- --------------enig5446E6CF1D9471C846BD74EC--