From: Jan Kiszka <jan.kiszka@siemens.com>
To: Sheng Yang <sheng@linux.intel.com>
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>
Subject: Re: [PATCH 1/1] Fix null DESTDIR in depmod execution
Date: Fri, 13 Nov 2009 12:24:48 +0100 [thread overview]
Message-ID: <4AFD4200.50904@siemens.com> (raw)
In-Reply-To: <1258093434-5193-1-git-send-email-sheng@linux.intel.com>
Sheng Yang wrote:
> commit 52ea5897fa9fdadf0cc1a5242a23ce3dab599769 "Use DESTDIR consitently on
> installation" add -b ${DESTDIR} to depmod. But the DESTDIR is default NULL,
> then depmod would report error.
>
> Set DESTDIR=/ as default
>
> Signed-off-by: Sheng Yang <sheng@linux.intel.com>
> ---
> Makefile | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index f406e3d..33ddc81 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -7,7 +7,7 @@ NONARCH_CONFIG = $(filter-out $(ARCH_CONFIG),X86 IA64)
>
> KVERREL = $(patsubst /lib/modules/%/build,%,$(KERNELDIR))
>
> -DESTDIR=
> +DESTDIR = /
>
> MAKEFILE_PRE = $(ARCH_DIR)/Makefile.pre
>
Yeah, thanks, applied.
But please add a prefix to your patch subjects in the future to identify
the subsystem they applies to.
Jan
--
Siemens AG, Corporate Technology, CT SE 2
Corporate Competence Center Embedded Linux
prev parent reply other threads:[~2009-11-13 11:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-13 6:23 [PATCH 1/1] Fix null DESTDIR in depmod execution Sheng Yang
2009-11-13 11:24 ` Jan Kiszka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AFD4200.50904@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
--cc=sheng@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox