From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jan Kiszka <jan.kiszka@siemens.com>
Subject: Re: [PATCH 1/1] Fix null DESTDIR in depmod execution
Date: Fri, 13 Nov 2009 12:24:48 +0100
Message-ID: <4AFD4200.50904@siemens.com>
References: <1258093434-5193-1-git-send-email-sheng@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>
To: Sheng Yang <sheng@linux.intel.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from david.siemens.de ([192.35.17.14]:19007 "EHLO david.siemens.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1756118AbZKMLYq (ORCPT <rfc822;kvm@vger.kernel.org>);
	Fri, 13 Nov 2009 06:24:46 -0500
In-Reply-To: <1258093434-5193-1-git-send-email-sheng@linux.intel.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Sheng Yang wrote:
> commit 52ea5897fa9fdadf0cc1a5242a23ce3dab599769 "Use DESTDIR consitently on
> installation" add -b ${DESTDIR} to depmod. But the DESTDIR is default NULL,
> then depmod would report error.
> 
> Set DESTDIR=/ as default
> 
> Signed-off-by: Sheng Yang <sheng@linux.intel.com>
> ---
>  Makefile |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index f406e3d..33ddc81 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -7,7 +7,7 @@ NONARCH_CONFIG = $(filter-out $(ARCH_CONFIG),X86 IA64)
>  
>  KVERREL = $(patsubst /lib/modules/%/build,%,$(KERNELDIR))
>  
> -DESTDIR=
> +DESTDIR = /
>  
>  MAKEFILE_PRE = $(ARCH_DIR)/Makefile.pre
>  

Yeah, thanks, applied.

But please add a prefix to your patch subjects in the future to identify
the subsystem they applies to.

Jan

-- 
Siemens AG, Corporate Technology, CT SE 2
Corporate Competence Center Embedded Linux