* [PATCH 1/1] Fix unable to detect libpci
@ 2009-11-13 6:22 Sheng Yang
2009-11-13 11:04 ` Juan Quintela
2009-11-15 12:57 ` Avi Kivity
0 siblings, 2 replies; 3+ messages in thread
From: Sheng Yang @ 2009-11-13 6:22 UTC (permalink / raw)
To: Avi Kivity; +Cc: Marcelo Tosatti, kvm, Sheng Yang, Juan Quintela
commit 75fe7882 "Test for libpci, not only for header" compile a libpci
test file. But the pciutils with defined PCI_COMPRESSED_IDS also need zlib
when compile, otherwise the compile would fail, and detection fail then
CC: Juan Quintela <quintela@redhat.com>
Signed-off-by: Sheng Yang <sheng@linux.intel.com>
---
configure | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/configure b/configure
index 9d3b840..5b08367 100755
--- a/configure
+++ b/configure
@@ -1477,8 +1477,8 @@ if test $kvm_cap_device_assignment = "yes" ; then
#endif
int main(void) { struct pci_access a; pci_init(&a); return 0; }
EOF
- if compile_prog "" "-lpci" ; then
- libs_softmmu="-lpci $libs_softmmu"
+ if compile_prog "" "-lpci -lz" ; then
+ libs_softmmu="-lpci -lz $libs_softmmu"
else
echo
echo "Error: libpci check failed"
--
1.5.4.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] Fix unable to detect libpci
2009-11-13 6:22 [PATCH 1/1] Fix unable to detect libpci Sheng Yang
@ 2009-11-13 11:04 ` Juan Quintela
2009-11-15 12:57 ` Avi Kivity
1 sibling, 0 replies; 3+ messages in thread
From: Juan Quintela @ 2009-11-13 11:04 UTC (permalink / raw)
To: Sheng Yang; +Cc: Avi Kivity, Marcelo Tosatti, kvm
Sheng Yang <sheng@linux.intel.com> wrote:
> commit 75fe7882 "Test for libpci, not only for header" compile a libpci
> test file. But the pciutils with defined PCI_COMPRESSED_IDS also need zlib
> when compile, otherwise the compile would fail, and detection fail then
>
> CC: Juan Quintela <quintela@redhat.com>
> Signed-off-by: Sheng Yang <sheng@linux.intel.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
configure already requires -lz sooner, i.e. nothing new, and everything
execpt *-user links with -lz already.
Later, Juan.
> ---
> configure | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/configure b/configure
> index 9d3b840..5b08367 100755
> --- a/configure
> +++ b/configure
> @@ -1477,8 +1477,8 @@ if test $kvm_cap_device_assignment = "yes" ; then
> #endif
> int main(void) { struct pci_access a; pci_init(&a); return 0; }
> EOF
> - if compile_prog "" "-lpci" ; then
> - libs_softmmu="-lpci $libs_softmmu"
> + if compile_prog "" "-lpci -lz" ; then
> + libs_softmmu="-lpci -lz $libs_softmmu"
> else
> echo
> echo "Error: libpci check failed"
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] Fix unable to detect libpci
2009-11-13 6:22 [PATCH 1/1] Fix unable to detect libpci Sheng Yang
2009-11-13 11:04 ` Juan Quintela
@ 2009-11-15 12:57 ` Avi Kivity
1 sibling, 0 replies; 3+ messages in thread
From: Avi Kivity @ 2009-11-15 12:57 UTC (permalink / raw)
To: Sheng Yang; +Cc: Marcelo Tosatti, kvm, Juan Quintela
On 11/13/2009 08:22 AM, Sheng Yang wrote:
> commit 75fe7882 "Test for libpci, not only for header" compile a libpci
> test file. But the pciutils with defined PCI_COMPRESSED_IDS also need zlib
> when compile, otherwise the compile would fail, and detection fail then
>
Applied, thanks.
--
error compiling committee.c: too many arguments to function
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-11-15 12:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-11-13 6:22 [PATCH 1/1] Fix unable to detect libpci Sheng Yang
2009-11-13 11:04 ` Juan Quintela
2009-11-15 12:57 ` Avi Kivity
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox