From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 2/2] qemu-kvm: x86: Add support for VCPU event states Date: Sun, 15 Nov 2009 17:10:38 +0200 Message-ID: <4B0019EE.3000501@redhat.com> References: <4AFB5123.7000301@web.de> <4AFB515D.1030202@web.de> <4B00087C.4060007@redhat.com> <4B000E71.3020901@web.de> <4B000FBB.3000600@redhat.com> <4B0010CD.7000406@web.de> <4B001253.9040207@redhat.com> <4B001808.2080503@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm , Juan Quintela To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:44961 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752759AbZKOPKe (ORCPT ); Sun, 15 Nov 2009 10:10:34 -0500 In-Reply-To: <4B001808.2080503@web.de> Sender: kvm-owner@vger.kernel.org List-ID: On 11/15/2009 05:02 PM, Jan Kiszka wrote: > > Where should I add "/* next version to use: 13 */", and who will take > care that this comment will also be kept up to date? The CPU vmstate is > already ordered according to logical groups, just look at earlier field. > Only recent KVM additions happened to create some version ordering as well. > Er, now I'm confused. 11 and 12 indeed do already exist, so how can you update 11 retroactively? Shouldn't you create 13 now? (and I meant: /* The above list is not sorted wrt version, watch out! */, but now I feel I'm missing something). -- error compiling committee.c: too many arguments to function