From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH 2/2] qemu-kvm: x86: Add support for VCPU event states Date: Sun, 15 Nov 2009 16:41:26 +0100 Message-ID: <4B002126.8020006@web.de> References: <4AFB5123.7000301@web.de> <4AFB515D.1030202@web.de> <4B00087C.4060007@redhat.com> <4B000E71.3020901@web.de> <4B000FBB.3000600@redhat.com> <4B0010CD.7000406@web.de> <4B001253.9040207@redhat.com> <4B001808.2080503@web.de> <4B0019EE.3000501@redhat.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigF8BFD3CBC60F9B9C363487E5" Cc: Marcelo Tosatti , kvm , Juan Quintela , Glauber Costa To: Avi Kivity Return-path: Received: from fmmailgate03.web.de ([217.72.192.234]:58620 "EHLO fmmailgate03.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753061AbZKOPl0 (ORCPT ); Sun, 15 Nov 2009 10:41:26 -0500 In-Reply-To: <4B0019EE.3000501@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigF8BFD3CBC60F9B9C363487E5 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Avi Kivity wrote: > On 11/15/2009 05:02 PM, Jan Kiszka wrote: >> >> Where should I add "/* next version to use: 13 */", and who will take >> care that this comment will also be kept up to date? The CPU vmstate i= s >> already ordered according to logical groups, just look at earlier fiel= d. >> Only recent KVM additions happened to create some version ordering as >> well. >> =20 >=20 > Er, now I'm confused. 11 and 12 indeed do already exist, so how can yo= u > update 11 retroactively? Oh, right, good that we discuss this. My patch dated back before the kvmclock addition, which IMHO incorrectly bumped the version numbers. I think the current policy in upstream is that we only increment once per qemu release, not per bit added. >=20 > Shouldn't you create 13 now? No, I rather think Glauber's 12 should be downgraded to 11 - unless it misses the qemu merge windows for 0.12. My extensions definitely target that release, thus will likely carry 11 in upstream. And we should really try to avoid diverging again. >=20 > (and I meant: /* The above list is not sorted wrt version, watch out! > */, but now I feel I'm missing something). >=20 Ok, can add such a note at the end. Jan --------------enigF8BFD3CBC60F9B9C363487E5 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAksAISoACgkQitSsb3rl5xSJBQCdGet/+HvISQea/vxefjWSdWCQ +wgAoKLY1EyJDp6Fwh1FFvRR4vNQ02Io =Iuqj -----END PGP SIGNATURE----- --------------enigF8BFD3CBC60F9B9C363487E5--