From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 2/2] qemu-kvm: x86: Add support for VCPU event states Date: Sun, 15 Nov 2009 17:50:33 +0200 Message-ID: <4B002349.5090309@redhat.com> References: <4AFB5123.7000301@web.de> <4AFB515D.1030202@web.de> <4B00087C.4060007@redhat.com> <4B000E71.3020901@web.de> <4B000FBB.3000600@redhat.com> <4B0010CD.7000406@web.de> <4B001253.9040207@redhat.com> <4B001808.2080503@web.de> <4B0019EE.3000501@redhat.com> <4B002126.8020006@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm , Juan Quintela , Glauber Costa To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:15782 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753192AbZKOPu2 (ORCPT ); Sun, 15 Nov 2009 10:50:28 -0500 In-Reply-To: <4B002126.8020006@web.de> Sender: kvm-owner@vger.kernel.org List-ID: On 11/15/2009 05:41 PM, Jan Kiszka wrote: > Avi Kivity wrote: > >> On 11/15/2009 05:02 PM, Jan Kiszka wrote: >> >>> Where should I add "/* next version to use: 13 */", and who will take >>> care that this comment will also be kept up to date? The CPU vmstate is >>> already ordered according to logical groups, just look at earlier field. >>> Only recent KVM additions happened to create some version ordering as >>> well. >>> >>> >> Er, now I'm confused. 11 and 12 indeed do already exist, so how can you >> update 11 retroactively? >> > Oh, right, good that we discuss this. My patch dated back before the > kvmclock addition, which IMHO incorrectly bumped the version numbers. I > think the current policy in upstream is that we only increment once per > qemu release, not per bit added. > What about stable releases? If we need to port a commit which adds a bit, we need to port the entire thing. (well version numbers don't work with nonlinear development anyway). >> Shouldn't you create 13 now? >> > No, I rather think Glauber's 12 should be downgraded to 11 - unless it > misses the qemu merge windows for 0.12. My extensions definitely target > that release, thus will likely carry 11 in upstream. And we should > really try to avoid diverging again. > Agree. Will commit the patches. >> (and I meant: /* The above list is not sorted wrt version, watch out! >> */, but now I feel I'm missing something). >> >> > Ok, can add such a note at the end. > > In upstream... -- error compiling committee.c: too many arguments to function