Re: [RFC][PATCH] qemu-kvm: Introduce writeback scope for cpu_synchronize_state

[Avi Kivity <avi@redhat.com>]

On 11/18/2009 11:50 AM, Jan Kiszka wrote:
>
>> INIT, too.
>>      
> INIT should be handled by queuing up the next mp_state.
>    

And clearing the previous queue; otherwise our queue is unbounded.

> BTW, as we do not inject mp_state changes from user space during
> runtime, the issue I saw with the current interface is not existing. We
> just need to add that queuing feature to asynchronous in-kernel mp_state
> changes, and we should be fine.
>
>
> Let's assume we will have such changes in future kernels: should
> qemu-kvm and qemu upstream also bother about older kernels and establish
> workarounds? Because then we need to find a cleaner approach than the
> current one, and my proposed patch comes into the game again.
>    

If we treat this as a bug, then we fix the older kernels too.

-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.