public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Alexander Graf <agraf@suse.de>
Cc: kvm list <kvm@vger.kernel.org>, Nick Piggin <npiggin@suse.de>,
	Glauber Costa <glommer@redhat.com>, Avi Kivity <avi@redhat.com>,
	"virtualization@lists.linux-foundation.org"
	<virtualization@lists.linux-foundation.org>,
	Alok Kataria <akataria@vmware.com>
Subject: Re: [PATCH] Replace kvm io delay pv-ops with linux magic
Date: Fri, 20 Nov 2009 09:54:05 +0800	[thread overview]
Message-ID: <4B05F6BD.3050402@goop.org> (raw)
In-Reply-To: <9466A245-8DB5-40FB-AE94-168117C2C692@suse.de>

On 11/20/09 07:58, Alexander Graf wrote:
>
> Am 19.11.2009 um 23:55 schrieb Jeremy Fitzhardinge <jeremy@goop.org>:
>
>> On 11/18/09 20:56, Alexander Graf wrote:
>>> Currently we use pv-ops to tell linux not to do anything on io_delay.
>>>
>>> While the basic idea is good IMHO, I don't see why we would need pv-ops
>>> for that. The io delay function already has a switch that can do
>>> nothing
>>> if you're so inclined.
>>>
>>> So here's a patch (stacked on top of the previous pv-ops series) that
>>> removes the io delay pv-ops hook and just sets the native io delay
>>> variable instead.
>>>
>>
>> Can you just get rid of the io_delay op altogether?  If KVM doesn't need
>> it, then nobody does.
>
> Sure, can do. That'd be a separate patch though.

Yep.  A patch each for VMI and Xen to remove the dependency, and a final
patch to remove the op.  Hm, looks like VMI has a specific ROM call for
io_delay; I wonder what it does.

    J

  reply	other threads:[~2009-11-20  1:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-18 12:56 [PATCH] Replace kvm io delay pv-ops with linux magic Alexander Graf
2009-11-19 22:55 ` Jeremy Fitzhardinge
2009-11-19 23:58   ` Alexander Graf
2009-11-20  1:54     ` Jeremy Fitzhardinge [this message]
2009-11-20  1:59       ` Alexander Graf
2009-11-20  2:08         ` Jeremy Fitzhardinge
2009-11-20 17:45           ` Alok Kataria

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B05F6BD.3050402@goop.org \
    --to=jeremy@goop.org \
    --cc=agraf@suse.de \
    --cc=akataria@vmware.com \
    --cc=avi@redhat.com \
    --cc=glommer@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=npiggin@suse.de \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox