From: Avi Kivity <avi@redhat.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: kvm <kvm@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Steven Rostedt <srostedt@redhat.com>
Subject: Re: kvmmmu tracing
Date: Tue, 24 Nov 2009 12:34:25 +0200 [thread overview]
Message-ID: <4B0BB6B1.5010302@redhat.com> (raw)
In-Reply-To: <1259057130.3985.1.camel@johannes.local>
On 11/24/2009 12:05 PM, Johannes Berg wrote:
> On Tue, 2009-11-24 at 11:50 +0200, Avi Kivity wrote:
>
>> On 11/23/2009 01:06 PM, Johannes Berg wrote:
>>
>>> Commit f691fe1da7e2715137d21ae5a80bec64db4625db is really broken wrt.
>>> the userspace interface for tracing because of the weird
>>> KVM_MMU_PAGE_PRINTK macro.
>>>
>>>
>>>
>> Can you explain what is wrong with it?
>>
> It's a big C expression that trace-cmd can't parse :)
>
Um, C can be easily parsed with a C compiler. I don't think you can
expect it to be a plain format string and argument list.
>> Is userspace reading mmutrace.h? When the structure attributes can be
>> exported via /sys/kernel/debug/tracing?
>>
> Yes ... look
> at /sys/kernel/debug/tracing/events/kvmmmu/kvm_mmu_unsync_page/format
> for instance.
>
You can fall back to using the attributes to build your own format string.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2009-11-24 10:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-23 11:06 kvmmmu tracing Johannes Berg
2009-11-23 14:58 ` Steven Rostedt
2009-11-23 15:46 ` Johannes Berg
2009-11-24 9:50 ` Avi Kivity
2009-11-24 10:05 ` Johannes Berg
2009-11-24 10:34 ` Avi Kivity [this message]
2009-11-24 14:08 ` Johannes Berg
2009-11-24 14:17 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B0BB6B1.5010302@redhat.com \
--to=avi@redhat.com \
--cc=johannes@sipsolutions.net \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=srostedt@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox