From: Avi Kivity <avi@redhat.com>
To: Gleb Natapov <gleb@redhat.com>
Cc: Jan Kiszka <jan.kiszka@siemens.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
kvm@vger.kernel.org, joerg.roedel@amd.com
Subject: Re: [patch 0/2] Handle multiple exceptions (fixes Win2003 reboot by triple fault)
Date: Wed, 25 Nov 2009 11:55:17 +0200 [thread overview]
Message-ID: <4B0CFF05.3060700@redhat.com> (raw)
In-Reply-To: <20091119155407.GE3193@redhat.com>
On 11/19/2009 05:54 PM, Gleb Natapov wrote:
>> It's actually less readable. I know 11 is between 10 and 13, but is
>> NP_VECTOR between TS_VECTOR and GP_VECTOR?
>>
>> This is better as a switch, or even:
>>
>> u8 exception_class[] = {
>> [PF_VECTOR] EXPT_PF,
>>
>> etc.
>>
> OK what about this then:
>
> From: Eddie Dong<eddie.dong@intel.com>
>
> Move Double-Fault generation logic out of page fault
> exception generating function to cover more generic case.
>
Much better.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2009-11-25 9:55 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-11 19:29 [patch 0/2] Handle multiple exceptions (fixes Win2003 reboot by triple fault) Marcelo Tosatti
2009-11-11 19:29 ` [patch 1/2] KVM: x86: handle double and triple faults for every exception Marcelo Tosatti
2009-11-11 20:07 ` Jan Kiszka
2009-11-11 20:41 ` Marcelo Tosatti
2009-11-11 21:02 ` Jan Kiszka
2009-11-11 21:40 ` Marcelo Tosatti
2009-11-15 12:30 ` Avi Kivity
2009-11-12 12:26 ` Gleb Natapov
2009-11-15 12:41 ` Avi Kivity
2009-11-15 12:51 ` Gleb Natapov
2009-11-15 13:11 ` Avi Kivity
2009-11-15 14:29 ` Jan Kiszka
2009-11-15 14:34 ` Avi Kivity
2009-11-15 14:36 ` Jan Kiszka
2009-11-11 19:29 ` [patch 2/2] KVM: x86: raise TSS exception for NULL CS and SS segments Marcelo Tosatti
2009-11-12 12:21 ` [patch 0/2] Handle multiple exceptions (fixes Win2003 reboot by triple fault) Gleb Natapov
2009-11-12 12:41 ` Jan Kiszka
2009-11-12 13:05 ` Gleb Natapov
2009-11-15 12:54 ` Avi Kivity
2009-11-19 15:54 ` Gleb Natapov
2009-11-20 15:55 ` Ryan Harper
2009-11-23 16:52 ` Marcelo Tosatti
2009-11-25 9:55 ` Avi Kivity [this message]
2009-11-25 13:03 ` Marcelo Tosatti
2009-11-12 16:07 ` Marcelo Tosatti
2009-11-12 18:03 ` Gleb Natapov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B0CFF05.3060700@redhat.com \
--to=avi@redhat.com \
--cc=gleb@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=joerg.roedel@amd.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox