From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [patch 0/2] Handle multiple exceptions (fixes Win2003 reboot
 by triple fault)
Date: Wed, 25 Nov 2009 11:55:17 +0200
Message-ID: <4B0CFF05.3060700@redhat.com>
References: <20091111192947.348198723@localhost.localdomain> <20091112122124.GB7392@redhat.com> <4AFC027B.1090101@siemens.com> <20091112130542.GD7392@redhat.com> <4AFFFA10.9020407@redhat.com> <20091119155407.GE3193@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Jan Kiszka <jan.kiszka@siemens.com>,
	Marcelo Tosatti <mtosatti@redhat.com>, kvm@vger.kernel.org,
	joerg.roedel@amd.com
To: Gleb Natapov <gleb@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:23059 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1758346AbZKYJzQ (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 25 Nov 2009 04:55:16 -0500
In-Reply-To: <20091119155407.GE3193@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 11/19/2009 05:54 PM, Gleb Natapov wrote:
>> It's actually less readable.  I know 11 is between 10 and 13, but is
>> NP_VECTOR between TS_VECTOR and GP_VECTOR?
>>
>> This is better as a switch, or even:
>>
>> u8 exception_class[] = {
>>     [PF_VECTOR] EXPT_PF,
>>
>> etc.
>>      
> OK what about this then:
>
> From: Eddie Dong<eddie.dong@intel.com>
>
> Move Double-Fault generation logic out of page fault
> exception generating function to cover more generic case.
>    

Much better.

-- 
error compiling committee.c: too many arguments to function