From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] PPC: Sync guest visible MMU state Date: Thu, 26 Nov 2009 14:50:36 +0200 Message-ID: <4B0E799C.80209@redhat.com> References: <1259234174-1104-1-git-send-email-agraf@suse.de> <4B0E7738.5030506@redhat.com> <4B0E78BC.5050901@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kvm-ppc , Benjamin Herrenschmidt , linuxppc-dev-mnsaURCQ41sdnm+yROfE0A@public.gmane.org To: Alexander Graf Return-path: In-Reply-To: <4B0E78BC.5050901-l3A5Bk7waGM@public.gmane.org> Sender: kvm-ppc-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: kvm.vger.kernel.org On 11/26/2009 02:46 PM, Alexander Graf wrote: > >> Please avoid unnamed unions in user-visible headers - they're a gcc >> extension. >> >> Yes, we have them elsewhere, but let's not add to the pile. >> > I'm open to scalable suggestions that don't break existing userspace code. > If I name the union now, existing qemu code will break. If I align the > pad array manually I'll definitely mess up something. > You can keep pvr out of the (named) union. -- error compiling committee.c: too many arguments to function