From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH] PPC: Sync guest visible MMU state
Date: Thu, 26 Nov 2009 15:20:09 +0200
Message-ID: <4B0E8089.9030403@redhat.com>
References: <1259234174-1104-1-git-send-email-agraf@suse.de> <4B0E7738.5030506@redhat.com> <4B0E78BC.5050901@suse.de> <4B0E799C.80209@redhat.com> <4B0E7FC0.3000803@suse.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kvm-ppc <kvm-ppc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Benjamin Herrenschmidt <benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>,
	linuxppc-dev-mnsaURCQ41sdnm+yROfE0A@public.gmane.org
To: Alexander Graf <agraf-l3A5Bk7waGM@public.gmane.org>
Return-path: <kvm-ppc-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
In-Reply-To: <4B0E7FC0.3000803-l3A5Bk7waGM@public.gmane.org>
Sender: kvm-ppc-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
List-Id: kvm.vger.kernel.org

On 11/26/2009 03:16 PM, Alexander Graf wrote:
>
>> You can keep pvr out of the (named) union.
>>      
>
> So we'd have
>
> sregs.padded.ppc64.slb?
>
>    

or sregs.u.ppc64.slb.

> I don't see how that is an improvement.
>    

Buildability takes precedence.

(an alternative is to drop the union, and add a BUILD_BUG_ON(sizeof...)).

-- 
error compiling committee.c: too many arguments to function