From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCHv5-repost 1/2] qemu: make cirrus init value pci spec compliant Date: Wed, 02 Dec 2009 14:52:33 +0200 Message-ID: <4B166311.7040300@redhat.com> References: <20091130190226.GB457@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Anthony Liguori , "qemu-devel@nongnu.org" , kvm-devel , Juan Quintela To: "Michael S. Tsirkin" Return-path: Received: from mx1.redhat.com ([209.132.183.28]:10031 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753490AbZLBMwa (ORCPT ); Wed, 2 Dec 2009 07:52:30 -0500 In-Reply-To: <20091130190226.GB457@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 11/30/2009 09:02 PM, Michael S. Tsirkin wrote: > PCI memory should be disabled at reset, otherwise > we might claim transactions at address 0. > I/O should also be disabled, although for cirrus > it is harmless to enable it as we do not > have I/O bar. > > Note: bios fix needed for this patch to work > was already applied: > previously bios incorrently assumed that it does not > need to enable i/o unless device has i/o bar. > Is this for qemu-kvm.git or qemu.git? -- error compiling committee.c: too many arguments to function