From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCHv2-repost] pcbios: enable io/memory unconditionally Date: Wed, 02 Dec 2009 15:28:17 +0200 Message-ID: <4B166B71.3070306@redhat.com> References: <20091008155256.GA13660@redhat.com> <20091130141722.GB25613@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Anthony Liguori , "qemu-devel@nongnu.org" , kvm-devel To: "Michael S. Tsirkin" Return-path: Received: from mx1.redhat.com ([209.132.183.28]:61741 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751312AbZLBN2X (ORCPT ); Wed, 2 Dec 2009 08:28:23 -0500 In-Reply-To: <20091130141722.GB25613@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 11/30/2009 04:17 PM, Michael S. Tsirkin wrote: > On Thu, Oct 08, 2009 at 05:52:56PM +0200, Michael S. Tsirkin wrote: > VGA adapters need to claim memory and i/o > transactions even if they do not have any > i/o or memory bars. E.g. PCI spec, page 297, > gives an example of such a device: > > Programming interface 0000 0000b > VGA-compatible controller. Memory > addresses 0A 0000h through 0B > FFFFh. I/O addresses 3B0h to 3BBh > and 3C0h to 3DFh and all aliases of > these addresses. > > While we could check for these devices and special-case them, it is > easier to fix this by enabling i/o and memory space unconditionally: > devices that do not support it will just ignore this setting. > > Applied, thanks. -- error compiling committee.c: too many arguments to function