From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 07/12] Rename kvm_apic_accept_pic_intr Date: Wed, 02 Dec 2009 16:24:54 +0200 Message-ID: <4B1678B6.7070606@redhat.com> References: <1259678201-11203-1-git-send-email-clalance@redhat.com> <1259678201-11203-8-git-send-email-clalance@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Chris Lalancette Return-path: Received: from mx1.redhat.com ([209.132.183.28]:54163 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754220AbZLBOYt (ORCPT ); Wed, 2 Dec 2009 09:24:49 -0500 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id nB2EOuni012198 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 2 Dec 2009 09:24:56 -0500 In-Reply-To: <1259678201-11203-8-git-send-email-clalance@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 12/01/2009 04:36 PM, Chris Lalancette wrote: > Call it kvm_apic_in_virtual_wire_mode, which is more > correct. Also change it to not only operate properly > on the boot CPU, but on any CPU. > I'm a little worried about the latter change. It effectively modifies the platform from having the PIC wired to just one cpu to having it wired to all CPUs. Let's leave that for now (but keep the rename). -- error compiling committee.c: too many arguments to function