From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 05/12] Make the IOAPIC lock a spinlock. Date: Wed, 02 Dec 2009 16:27:11 +0200 Message-ID: <4B16793F.6070405@redhat.com> References: <1259678201-11203-1-git-send-email-clalance@redhat.com> <1259678201-11203-6-git-send-email-clalance@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Chris Lalancette Return-path: Received: from mx1.redhat.com ([209.132.183.28]:62874 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751824AbZLBO1G (ORCPT ); Wed, 2 Dec 2009 09:27:06 -0500 Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id nB2ERCtw025676 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 2 Dec 2009 09:27:13 -0500 In-Reply-To: <1259678201-11203-6-git-send-email-clalance@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 12/01/2009 04:36 PM, Chris Lalancette wrote: > In order to be able to call kvm_set_irq from an interrupt > context, the IOAPIC lock can't be a (possibly sleeping) mutex. > Convert it to a spinlock. > The ioapic can call various notifiers (ack_notifiers, mask_notifiers). Have you validated that all notifier callbacks are safe wrt the lock (that is, they don't sleep or send IPIs)? -- error compiling committee.c: too many arguments to function