Re: [PATCH] qemu-kvm: x86: Fix mismerge in cpu_post_load

[Avi Kivity <avi@redhat.com>]

On 12/03/2009 08:21 PM, Jan Kiszka wrote:
> Merge 8e2c5ec2f6 forgot to restore some qemu-kvm-specific hooks in
> cpu_post_load. mp_state was readded later on, but tsc was missing,
> breaking the guest timing after resume. Also, reset of halt was dropped
> which is obviously required for in-kernel irqchip.
>    

Applied, thanks.

> BTW, this patch just made me realize that the TSC MSR belongs to the
> list states that should not be written back unconditionally. Upstream
> does this currently, qemu-kvm not (at the price one more kvm-specific
> hook into generic code).

   Yet another reminder why we don't rewrite, only refactor.

> Unlike the other states we discussed, this one
> is not "fixable" in the kernel. So I tend to think there is a real need
> for my write-back scope abstraction - which would also be able to handle
> the other states cleanly, both in upstream and here.
>    

Yes.  Gleb suggested treating mpstate/nmi as part of the APIC state 
(which makes sense), which would work, as APIC state is not 
automatically written back.  But the tsc msr would need special treatment.


-- 
error compiling committee.c: too many arguments to function